tabish121 commented on issue #3079: ARTEMIS-2706 Use FrameSize to decide when to flush large messages URL: https://github.com/apache/activemq-artemis/pull/3079#issuecomment-613656867 The change doesn't account for the Transfer performative encoded in front of the payload as was mentioned in Robbie's comment so you end up now with an odd distribution of frames where you get one big on and then one tiny one which can be observed in the AMQP large message test by turning on frame tracing. > [269870574:0] <- Transfer{handle=0, deliveryId=199, deliveryTag=\x00, messageFormat=0, settled=false, more=true, rcvSettleMode=null, state=null, resume=false, aborted=false, batchable=false} (32744) "AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA"...(truncated) > [269870574:0] <- Transfer{handle=0, deliveryId=199, deliveryTag=\x00, messageFormat=0, settled=false, more=true, rcvSettleMode=null, state=null, resume=false, aborted=false, batchable=false} (23) "AAAAAAAAAAAAAAAAAAAAAAA"
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
