gtully commented on pull request #3568: URL: https://github.com/apache/activemq-artemis/pull/3568#issuecomment-834277269
Indeed, I did some sanity in a debugger to verify close was being called via some of the tests but more tests may be necessary. Tracking state in close is natural and tracking producers/consumer in a session is also natural to trap the close. the callback registration looked unnatural to me and if it needs to be unregistered (as it does) it needs to be in close and if close is not called we will still have some potential problem. let me see if I can write some more tests around this. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
