gemmellr commented on pull request #3568: URL: https://github.com/apache/activemq-artemis/pull/3568#issuecomment-834289173
The specific close method currently calling the cleanup doesnt looked to be used, whilst for the other close method (there are 2) there is no guarantee it will happen generally (though it will in the described case) since things dont need to the producer link rather than the parent session or connection, and things obviously drop, so relying on that close being called for all such cleanup is never going to be fullproof. That said, the producer already looks to be registered with the session independent of that callback, so there are likely other ways to achieve that 'parent being cleaned up' triggered behaviour than with the callback which is being leaked. Or just change the registration so it doesnt retain the entire ProtonAbstractReceiver, rather just what it needs to close the outstanding file. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
