clebertsuconic commented on a change in pull request #3580:
URL: https://github.com/apache/activemq-artemis/pull/3580#discussion_r632767871



##########
File path: artemis-server/src/test/resources/ConfigurationTest-full-config.xml
##########
@@ -406,6 +406,9 @@
       <page-max-concurrent-io>17</page-max-concurrent-io>
       <read-whole-page>true</read-whole-page>
       <journal-directory>somedir2</journal-directory>
+      <journal-history-directory>history</journal-history-directory>

Review comment:
       @michaelandrepearce some time ago, I talked to an Architect at my job 
who wanted to get diffs from the broker and send over to another site from time 
to time. 
   
   This kind of feature would be useful for such case maybe?
   
   
   It wouldn't hurt to have it though.. it's just an additional option.
   
   
   I am thinking to have a commented out xml on the broker.xml that will have 7 
days, 10G as the config. So if users just uncomment that they will have the 7 
days and 10G max disk.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to