michaelandrepearce commented on a change in pull request #3580:
URL: https://github.com/apache/activemq-artemis/pull/3580#discussion_r632888592
##########
File path: artemis-server/src/main/resources/schema/artemis-configuration.xsd
##########
@@ -675,6 +675,82 @@
</xsd:annotation>
</xsd:element>
+ <xsd:element name="journal-retention" maxOccurs="1" minOccurs="0">
+ <xsd:annotation>
+ <xsd:documentation>
+ Configuration about the journal retention configuration.
+ </xsd:documentation>
+ </xsd:annotation>
+ <xsd:complexType>
+ <xsd:attribute name="unit" use="required">
+ <xsd:annotation>
+ <xsd:documentation>
+ This configures the period type to use on limit. By
default it is DAYS.
+ </xsd:documentation>
+ </xsd:annotation>
+ <xsd:simpleType>
+ <xsd:restriction base="xsd:string">
Review comment:
Also why seperate the unit and the period why not as a single attribute
string like for storage where its value and scaler
E.g. 2040594944ms 360s 4h 7d and if no unit default to ms
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
