gemmellr commented on pull request #3812: URL: https://github.com/apache/activemq-artemis/pull/3812#issuecomment-952345776
The issue with respecting both if set is that the existing max-disk-usage has a default and so its essentially always on even without config, unless manually disabled with config, plus the two settings are very likely to disagree on when to block if both have values. Fair enough if it logs a warning about that, but it seems like it just complicates things to try handlng both, only to almost certainly not give actual desired behaviour, plus always warning about both being set. Thats effectively just requiring users must always explicitly manually configure a disabling value for max-disk-usage in addition to configuring a value for min-disk-free, in order to get the desired behaviour and suppress the warning. It seems more straight forward to me for both impl and users to just say min-disk-free always overrides max-disk-usage when it is configured, i.e you are explicitly choosing to use that feature over the other by setting it to anything. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
