haanhvu commented on a change in pull request #3812:
URL: https://github.com/apache/activemq-artemis/pull/3812#discussion_r740124331



##########
File path: 
tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/amqp/GlobalDiskFullTest.java
##########
@@ -51,11 +51,19 @@ public void tick(long usableSpace, long totalSpace) {
          }
 
          @Override
-         public void over(long usableSpace, long totalSpace) {

Review comment:
       @clebertsuconic for max-disk-usage, over means violate. But for 
min-disk-free, over means ok (not violate).
   
   I know changing a method name of a public interface can be a flag. But I did 
it for the sake of clarification.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to