gemmellr commented on pull request #3846: URL: https://github.com/apache/activemq-artemis/pull/3846#issuecomment-973292765
> The only thing I did not do was the optional aspect of the library. > > Maven will internally still use the unshaded jar for certain features, and when that happens the dependency still valid, but when using outside of the context of artemis build the shaded version will not have the dependency. I checked that and it's working... > > (I needed the dependency for certain tests) > You dropped the plugin version removal change in the commons pom too, that should be fixed I would suggest to try and leave them optional, and e.g. add the deps back as test scope deps if still needed in places to run tests using the wrapper, due to maven running them against the original classes rather than the shaded ones in the packaged jar. As you showed in your original efforts, leaving it this way would mean other modules can still compile with the very changes present that this is aiming to prevent, something that likely wouldnt be picked up until after it was released. At least with them optional they cant compile. If adding them as test deps where needed works then at least they arent hard compile time deps except for the tests which is much less of an issue, and you can be sure no hard usages are added in other modules unless they themselves already depend on the bits. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
