gemmellr commented on pull request #3846: URL: https://github.com/apache/activemq-artemis/pull/3846#issuecomment-973324176
Yep, maven tests classes since the package phase is seperate and only comes later, and alas shading is at package time. I'm just saying given the two choices, if using compile+optional in commons with test scope deps elsewhere as needed does works, then I would probably choose that unless there is some larger downside, otherwise things just remain susceptible to this same compatibility problem arising again by accident again without being noticed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
