gemmellr commented on a change in pull request #3876:
URL: https://github.com/apache/activemq-artemis/pull/3876#discussion_r766632152
##########
File path:
artemis-protocols/artemis-openwire-protocol/src/main/java/org/apache/activemq/artemis/core/protocol/openwire/OpenWireProtocolManager.java
##########
@@ -236,6 +238,18 @@ public void removeConnection(ConnectionInfo info,
Throwable error) throws Invali
}
}
+ /*** if set, the OpenWire connection will bypass the tcpReadBuferSize and
use this value instead.
+ * This is by default -1, and it should not be used unless in extreme
situations like on a slow storage. */
+ public int getMaxActorSize() {
+ return maxActorSize;
+ }
+
+ public OpenWireProtocolManager setMaxActorSize(int maxActorSize) {
+ System.out.println("max actor size " + maxActorSize);
Review comment:
Also, maxActorSize feels off as a name given it specifically isnt
actually a max and can be exceeded, and indeed doesnt cause anything to happen
until it has already been exceeded.
Again, not sure on great alternatives though...actorSizeThreshold?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
