gemmellr commented on a change in pull request #3876:
URL: https://github.com/apache/activemq-artemis/pull/3876#discussion_r766752717
##########
File path:
artemis-server/src/main/java/org/apache/activemq/artemis/core/paging/impl/PagingStoreImpl.java
##########
@@ -713,6 +713,9 @@ public boolean checkMemory(boolean runOnFailure, final
Runnable runWhenAvailable
}
} else if (pagingManager.isDiskFull() || addressFullMessagePolicy ==
AddressFullMessagePolicy.BLOCK && (maxSize != -1 || usingGlobalMaxSize)) {
if (pagingManager.isDiskFull() || maxSize > 0 && sizeInBytes.get() >=
maxSize || pagingManager.isGlobalFull()) {
+ if (runWhenBlocking != null) {
+ runWhenBlocking.run();
Review comment:
Its unclear to me that you can trust this PR without changing it, given
the fact it would be running tasks when it shouldnt, and these are now
coordinating on important state.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
