erwindon commented on pull request #3891: URL: https://github.com/apache/activemq-artemis/pull/3891#issuecomment-1004707761
> would be possible to add a test for this? What should be tested then? only this function? or the complete context where it is used, i.e. message-expiry? Each protocol has its own `toPropertyMap` function. Neither of these have dedicated tests. This is a fix/improvement for the one on the amqp side only. The amount of work for this may quickly become too much for me. In that case, alternative #2 or #3 (as listed in https://issues.apache.org/jira/browse/ARTEMIS-3623) may be more appropriate. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
