erwindon commented on pull request #3891: URL: https://github.com/apache/activemq-artemis/pull/3891#issuecomment-1004952018
> do you consider this a bug or an improvement BTW? I see that I filed the issue under "bug". Without a specification (e.g. https://en.wikipedia.org/wiki/Software_requirements_specification) it is always a thin line between a "bug" and "something-that-could-have-been-done-different". In this case, information that was previously available (the data-type) was removed. IMHO, that makes it more a bug than an improvement. There are 2 use cases for this field: (1) applications consuming these messages, and (2) viewing these messages in the console. Previously the difference between a numeric-field and text-field was unnoticeable in the console until I applied formatting functions on it in an earlier PR. So I am to blame for making a small issue bigger. And I also admit that the proposed change is not formally complete, as it tests for numeric fields only. Any boolean/date/etc that appears in that location is still converted to text. The main reason for this simplification is that I wanted to solve the presentation issue first. And to my knowledge that happens only for one numeric field. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
