laeubi commented on pull request #3470: URL: https://github.com/apache/activemq-artemis/pull/3470#issuecomment-1013623826
You can see the implementations here: https://github.com/apache/activemq-artemis/tree/main/artemis-protocols/artemis-amqp-protocol/src/main/java/org/apache/activemq/artemis/protocol/amqp/sasl/scram so it is SHA256+SHA512. Support for SHA1 was dropped. If you have a strong use-case for SHA1 you should open a new ticket describing it, its really not that hard to add other mechanisms. Effectively you have to to do these things; 1. Add a new SCRAM method [here](https://github.com/apache/activemq-artemis/blob/main/artemis-server/src/main/java/org/apache/activemq/artemis/spi/core/security/scram/SCRAM.java) 2. Add a new Factory (see [here for an example](https://github.com/apache/activemq-artemis/blob/main/artemis-protocols/artemis-amqp-protocol/src/main/java/org/apache/activemq/artemis/protocol/amqp/sasl/scram/SHA512SCRAMServerSASLFactory.java)) 3. Add it it in the [list of mechanisms](https://github.com/apache/activemq-artemis/blob/main/artemis-protocols/artemis-amqp-protocol/src/main/resources/META-INF/services/org.apache.activemq.artemis.protocol.amqp.sasl.ServerSASLFactory) so it could be discovered. I even did this once for the md5 set of hash functions for demonstration purpose so you are not limited ti SHA-X at all... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
