mattrpav commented on a change in pull request #729: URL: https://github.com/apache/activemq/pull/729#discussion_r792163073
########## File path: activemq-client/src/main/java/org/apache/activemq/ActiveMQContext.java ########## @@ -0,0 +1,477 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.activemq; + +import java.io.Serializable; + +import javax.jms.BytesMessage; +import javax.jms.ConnectionMetaData; +import javax.jms.Destination; +import javax.jms.ExceptionListener; +import javax.jms.IllegalStateRuntimeException; +import javax.jms.JMSConsumer; +import javax.jms.JMSContext; +import javax.jms.JMSException; +import javax.jms.JMSProducer; +import javax.jms.JMSRuntimeException; +import javax.jms.MapMessage; +import javax.jms.Message; +import javax.jms.ObjectMessage; +import javax.jms.Queue; +import javax.jms.QueueBrowser; +import javax.jms.Session; +import javax.jms.StreamMessage; +import javax.jms.TemporaryQueue; +import javax.jms.TemporaryTopic; +import javax.jms.TextMessage; +import javax.jms.Topic; + +import org.apache.activemq.util.JMSExceptionSupport; + +/** + * In terms of the JMS 1.1 API a JMSContext should be thought of as + * representing both a Connection and a Session. Although the simplified + * API removes the need for applications to use those objects, the concepts + * of connection and session remain important. A connection represents a + * physical link to the JMS server and a session represents a + * single-threaded context for sending and receiving messages. + * + * + * @see javax.jms.JMSContext + */ + +public class ActiveMQContext implements JMSContext { + + private static final boolean DEFAULT_AUTO_START = true; + + private final ActiveMQConnection activemqConnection; + private ActiveMQSession activemqSession = null; + + // Configuration + private boolean autoStart = DEFAULT_AUTO_START; + private final int sessionMode; + + // State + private boolean closeInvoked = false; + private ActiveMQMessageProducer activemqMessageProducer = null; + + ActiveMQContext(final ActiveMQConnection activemqConnection) { + this.activemqConnection = activemqConnection; + this.sessionMode = AUTO_ACKNOWLEDGE; + } + + ActiveMQContext(final ActiveMQConnection activemqConnection, final int sessionMode) { + this.activemqConnection = activemqConnection; + this.sessionMode = sessionMode; + } + + @Override + public JMSContext createContext(int sessionMode) { + return new ActiveMQContext(activemqConnection, sessionMode); + } + + @Override + public JMSProducer createProducer() { + return new ActiveMQProducer(this, getCreatedActiveMQMessageProducer()); + } + + @Override + public String getClientID() { + try { + return this.activemqConnection.getClientID(); + } catch (JMSException e) { + throw JMSExceptionSupport.convertToJMSRuntimeException(e); + } + } + + @Override + public void setClientID(String clientID) { + try { + this.activemqConnection.setClientID(clientID); + } catch (JMSException e) { + throw JMSExceptionSupport.convertToJMSRuntimeException(e); + } + } + + @Override + public ConnectionMetaData getMetaData() { + checkContextState(); + try { + return this.activemqConnection.getMetaData(); + } catch (JMSException e) { + throw JMSExceptionSupport.convertToJMSRuntimeException(e); + } + } + + @Override + public ExceptionListener getExceptionListener() { + checkContextState(); + try { + return this.activemqConnection.getExceptionListener(); + } catch (JMSException e) { + throw JMSExceptionSupport.convertToJMSRuntimeException(e); + } + } + + @Override + public void setExceptionListener(ExceptionListener listener) { + checkContextState(); + try { + this.activemqConnection.setExceptionListener(listener); + } catch (JMSException e) { + throw JMSExceptionSupport.convertToJMSRuntimeException(e); + } + } + + @Override + public void start() { + checkContextState(); + try { + this.activemqConnection.start(); + } catch (JMSException e) { + throw JMSExceptionSupport.convertToJMSRuntimeException(e); + } + } + + @Override + public void stop() { + checkContextState(); + try { + this.activemqConnection.stop(); + } catch (JMSException e) { + throw JMSExceptionSupport.convertToJMSRuntimeException(e); + } + } + + @Override + public void setAutoStart(boolean autoStart) { + this.autoStart = autoStart; + } + + @Override + public boolean getAutoStart() { + return this.autoStart; + } + + @Override + public void close() { + try { + closeInvoked = true; + if(this.activemqMessageProducer != null) { + this.activemqMessageProducer.close(); + } + if (this.activemqSession != null) { + this.activemqSession.close(); + } + this.activemqConnection.close(); Review comment: Good catch, I'll work on a fix. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
