gemmellr commented on a change in pull request #729: URL: https://github.com/apache/activemq/pull/729#discussion_r792545446
########## File path: activemq-client/src/main/java/org/apache/activemq/ActiveMQProducer.java ########## @@ -0,0 +1,547 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.activemq; + +import java.io.Serializable; +import java.util.Arrays; +import java.util.HashMap; +import java.util.Map; +import java.util.Set; + +import javax.jms.BytesMessage; +import javax.jms.CompletionListener; +import javax.jms.Destination; +import javax.jms.JMSException; +import javax.jms.JMSProducer; +import javax.jms.MapMessage; +import javax.jms.Message; +import javax.jms.MessageFormatRuntimeException; +import javax.jms.MessageProducer; +import javax.jms.ObjectMessage; +import javax.jms.TextMessage; + +import org.apache.activemq.util.JMSExceptionSupport; +import org.apache.activemq.util.TypeConversionSupport; + +public class ActiveMQProducer implements JMSProducer { + + private final ActiveMQContext activemqContext; + private final MessageProducer activemqMessageProducer; + + // QoS override of defaults on a per-JMSProducer instance basis + private String correlationId = null; + private byte[] correlationIdBytes = null; + private Long deliveryDelay = null; + private Integer deliveryMode = null; + private Integer priority = null; + private Destination replyTo = null; + private Long timeToLive = null; + private String type = null; + + // Properties applied to all messages on a per-JMS producer instance basis + private Map<String, Object> messageProperties = null; + + ActiveMQProducer(ActiveMQContext activemqContext, MessageProducer activemqMessageProducer) { + this.activemqContext = activemqContext; + this.activemqMessageProducer = activemqMessageProducer; + } + + @Override + public JMSProducer send(Destination destination, Message message) { + try { + if(this.correlationId != null) { + message.setJMSCorrelationID(this.correlationId); + } + + if(this.correlationIdBytes != null) { + message.setJMSCorrelationIDAsBytes(this.correlationIdBytes); + } + + if(this.replyTo != null) { + message.setJMSReplyTo(this.replyTo); + } + + if(this.type != null) { + message.setJMSType(this.type); + } + + if(!messageProperties.isEmpty()) { + for(Map.Entry<String, Object> propertyEntry : messageProperties.entrySet()) { + message.setObjectProperty(propertyEntry.getKey(), propertyEntry.getValue()); + } + } + + activemqMessageProducer.send(destination, message, getDeliveryMode(), getPriority(), getTimeToLive()); + } catch (JMSException e) { + throw JMSExceptionSupport.convertToJMSRuntimeException(e); + } + return this; + } + + @Override + public JMSProducer send(Destination destination, String body) { + TextMessage textMessage = activemqContext.createTextMessage(body); + send(destination, textMessage); + return this; + } + + @Override + public JMSProducer send(Destination destination, Map<String, Object> body) { + MapMessage mapMessage = activemqContext.createMapMessage(); + + if (body != null) { + try { + for (Map.Entry<String, Object> mapEntry : body.entrySet()) { + final String key = mapEntry.getKey(); + final Object value = mapEntry.getValue(); + final Class<?> valueObject = value.getClass(); + if (String.class.isAssignableFrom(valueObject)) { + mapMessage.setString(key, String.class.cast(value)); + } else if (Integer.class.isAssignableFrom(valueObject)) { + mapMessage.setInt(key, Integer.class.cast(value)); + } else if (Long.class.isAssignableFrom(valueObject)) { + mapMessage.setLong(key, Long.class.cast(value)); + } else if (Double.class.isAssignableFrom(valueObject)) { + mapMessage.setDouble(key, Double.class.cast(value)); + } else if (Boolean.class.isAssignableFrom(valueObject)) { + mapMessage.setBoolean(key, Boolean.class.cast(value)); + } else if (Character.class.isAssignableFrom(valueObject)) { + mapMessage.setChar(key, Character.class.cast(value)); + } else if (Short.class.isAssignableFrom(valueObject)) { + mapMessage.setShort(key, Short.class.cast(value)); + } else if (Float.class.isAssignableFrom(valueObject)) { + mapMessage.setFloat(key, Float.class.cast(value)); + } else if (Byte.class.isAssignableFrom(valueObject)) { + mapMessage.setByte(key, Byte.class.cast(value)); + } else if (byte[].class.isAssignableFrom(valueObject)) { + byte[] array = byte[].class.cast(value); + mapMessage.setBytes(key, array, 0, array.length); + } else { + mapMessage.setObject(key, value); + } + } + } catch (JMSException e) { + throw new MessageFormatRuntimeException(e.getMessage()); + } + } + send(destination, mapMessage); + return this; + } + + @Override + public JMSProducer send(Destination destination, byte[] body) { + BytesMessage bytesMessage = activemqContext.createBytesMessage(); + + try { + if(body != null) { + bytesMessage.writeBytes(body); + } + send(destination, bytesMessage); + } catch (JMSException e) { + throw JMSExceptionSupport.convertToJMSRuntimeException(e); + } + return this; + } + + @Override + public JMSProducer send(Destination destination, Serializable body) { + ObjectMessage objectMessage = activemqContext.createObjectMessage(body); + send(destination, objectMessage); + return this; + } + + @Override + public JMSProducer setDisableMessageID(boolean value) { Review comment: A JMSProducer can have its own value for setDisableMessageID like any producer, which is set per-producer. However, given its 'light weight' nature you are implementing it by wrapping an _underlying_ anonymous MessageProducer which has its own distinct value for this setting. Tim's spot-on observation is that this call should only influence _this_ JMSProducer to retain the setting and apply it with each send made using _this_ JMSProducer, but it should not cause the _underlying_ MessageProducer to retain that setting, since that is an impl detail being shared amongst potentially _many_ JMSProducer instances, and the others of which may not have had setDisableMessageID called for them. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
