jbertram commented on a change in pull request #3907:
URL: https://github.com/apache/activemq-artemis/pull/3907#discussion_r792960826
##########
File path:
artemis-protocols/artemis-mqtt-protocol/src/main/java/org/apache/activemq/artemis/core/protocol/mqtt/MQTTSession.java
##########
@@ -212,4 +234,42 @@ public CoreMessageObjectPools getCoreMessageObjectPools() {
return coreMessageObjectPools;
}
+ public boolean is5() {
+ return five;
+ }
+
+ public void set5(boolean five) {
Review comment:
That's a fair point. However, I'd prefer to leave it as a `boolean` for
now and change it later if/when necessary. It will be just as easy to change it
later as it would be to change it now. In my opinion the benefit of not
changing it now is that using a `boolean` is more clear.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
