clebertsuconic commented on pull request #3907: URL: https://github.com/apache/activemq-artemis/pull/3907#issuecomment-1023283334
The only thing I don't like on this PR is the "leakage" of getMqttSessionScanInterval on ConfigurationImpl. I would prefer it being a bean util property on the MQTT Protocol Manager. Make the scanInterval as part of the default configuration so it's easier for users to see it in there. Do you really need it on the Configurationimpl / Configuration or would you be able to make it part of MQTTProtocolManager and a beanutil property? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
