Havret commented on a change in pull request #18:
URL:
https://github.com/apache/activemq-nms-openwire/pull/18#discussion_r795217746
##########
File path: src/Transport/ResponseCorrelator.cs
##########
@@ -85,15 +87,40 @@ public override FutureResponse AsyncRequest(Command command)
return future;
}
- public override Response Request(Command command, TimeSpan timeout)
+ public override Task<Response> RequestAsync(Command command, TimeSpan
timeout)
{
+ TaskCompletionSource<Response> taskCompletionSource = new
TaskCompletionSource<Response>(TaskCreationOptions.RunContinuationsAsynchronously);
+ if (timeout.TotalMilliseconds > 0)
+ {
+ CancellationTokenSource ct = new
CancellationTokenSource(timeout);
+ ct.Token.Register(() =>
+ {
+ taskCompletionSource.TrySetException(new
RequestTimedOutException(timeout));
+ }, false);
+ }
+
FutureResponse future = AsyncRequest(command);
- future.ResponseTimeout = timeout;
- Response response = future.Response;
- return response;
+
+ _ = future.Task.ContinueWith(t =>
Review comment:
The logic you are applying here should be applied as part of
`OnCommand`. You basically should resolve promise there.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
