Havret commented on a change in pull request #18:
URL:
https://github.com/apache/activemq-nms-openwire/pull/18#discussion_r821120898
##########
File path: src/AdvisoryConsumer.cs
##########
@@ -44,7 +45,7 @@ internal AdvisoryConsumer(Connection connection, ConsumerId
consumerId) : base()
this.info.NoLocal = true;
this.connection.AddDispatcher(consumerId, this);
- this.connection.SyncRequest(this.info);
+ this.connection.SyncRequestAsync(this.info).GetAsyncResult();
Review comment:
From calling stack it seems this is used in async flow, but you're
blocking it here. I guess this should be changed, so first, you asynchronously
create a resource and then inject it here via the constructor.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
