gemmellr commented on a change in pull request #662:
URL: https://github.com/apache/activemq/pull/662#discussion_r812243638
##########
File path: activemq-all/pom.xml
##########
@@ -109,9 +105,8 @@
<include>org.apache.geronimo.specs:geronimo-j2ee-management_1.1_spec</include>
<include>org.apache.geronimo.specs:geronimo-annotation_1.0_spec</include>
<include>org.slf4j:slf4j-api</include>
- <include>org.slf4j:slf4j-log4j12</include>
+ <include>org.apache.logging:log4j-slf4j-impl</include>
Review comment:
Commenting about the line below, seems odd that it is including
org.slf4j:jcl-over-slf4j when you just removed the explicit dependency on it,
and later in the root pom the version-management entry for it. Since there
remains commons-logging use, im not too clear why? Do some of the log4j2 bits
bridge that directly?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
