gemmellr commented on a change in pull request #662:
URL: https://github.com/apache/activemq/pull/662#discussion_r812935277
##########
File path: activemq-all/pom.xml
##########
@@ -109,9 +105,8 @@
<include>org.apache.geronimo.specs:geronimo-j2ee-management_1.1_spec</include>
<include>org.apache.geronimo.specs:geronimo-annotation_1.0_spec</include>
<include>org.slf4j:slf4j-api</include>
- <include>org.slf4j:slf4j-log4j12</include>
+ <include>org.apache.logging:log4j-slf4j-impl</include>
Review comment:
Yes the comment wasnt about slf4j-log4j12 (that removal is obvious),
just the line below it as noted (which didnt change and so couldnt be commented
on, which is explicitly including org.slf4j:jcl-over-slf4j, as is the assemby,
yet the dependencyManagement for it was just removed in place of using the same
property in the assembly. I dont see why you would remove the version
management if still actually using it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
