jbonofre commented on a change in pull request #662:
URL: https://github.com/apache/activemq/pull/662#discussion_r812922429
##########
File path: pom.xml
##########
@@ -442,29 +441,6 @@
<!-- =============================== -->
<!-- Required dependencies -->
<!-- =============================== -->
- <dependency>
- <groupId>commons-logging</groupId>
- <artifactId>commons-logging</artifactId>
- <version>${commons-logging-version}</version>
- <exclusions>
- <exclusion>
- <groupId>avalon-framework</groupId>
- <artifactId>avalon-framework</artifactId>
- </exclusion>
- <exclusion>
- <groupId>logkit</groupId>
- <artifactId>logkit</artifactId>
- </exclusion>
- <exclusion>
- <groupId>log4j</groupId>
- <artifactId>log4j</artifactId>
- </exclusion>
- <exclusion>
- <groupId>javax.servlet</groupId>
- <artifactId>servlet-api</artifactId>
- </exclusion>
- </exclusions>
- </dependency>
Review comment:
I remember now, I removed from the dependency management because not
used by ActiveMQ directly. However, indeed, it's important for dependency that
use commons-logging by transitity (like activeio). I readding the
commons-logging dependency management.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
