gemmellr commented on pull request #3999: URL: https://github.com/apache/activemq-artemis/pull/3999#issuecomment-1084792170
There are lots of hard coded versions for dependencies and plugins in the poms. The versions should be set in properties and used via dependencyManagement and pluginManagement to convey the version to where needed. I think in many cases they will already be used that way elsewhere in the build, possibly with the same versions, which makes the hard coding even worse. There look to be lots of tabbed indents introduced in the xml files instead of spaces, these should be fixed. In some cases existing spaces were converted to tabs and indents changed, creating a bunch of seemingly unnecessary change across fairly big files, the tabs should be fixed and it would be good to unwind unnecessary changes as the diff will be large enough as it is. Searching [the current diff](https://patch-diff.githubusercontent.com/raw/apache/activemq-artemis/pull/3999.diff) for tabs currently gives a lot of results. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
