gemmellr commented on PR #3999: URL: https://github.com/apache/activemq-artemis/pull/3999#issuecomment-1099675775
I did read the JIRA before reviewing, as I said that aspect wasnt (still isnt) clear to me, in part as I simply dont use these bits, but mainly due to the PR essentially contradicting itself with adding documentation saying you "must" build your own and another example doing that. I dont think this is dead in the slightest. I do think there was a bunch of previous feedback you hadnt yet actioned (until perhaps now) even when repeated, or actually possibly still havent in the case of getting rid of the merge commits and squashing your changes to minimise the (now-getting-silly) number of commits, and rebasing things against the current main. I havent had a chance to look at what you have now added since my previous comments yet, I will take another look when back from vacation next week. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
