gemmellr commented on PR #21: URL: https://github.com/apache/activemq-nms-openwire/pull/21#issuecomment-1122105746
I'm not set up for any kind of NMS stuff so its not one I will be validating, just wanted to note why the concept as described seems unlikely to cause issue (also being what all the Java clients always did) and even seems appropriate regardless at this point. I would reiterate Michael's comment about creating a JIRA and squashing (+rebasing if needed) the commits, noone going to merge 4 commits to change 2 words that should be updated at the same time. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
