clebertsuconic commented on code in PR #4101:
URL: https://github.com/apache/activemq-artemis/pull/4101#discussion_r891684103


##########
artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/QueueImpl.java:
##########
@@ -207,8 +208,8 @@ private void checkIDSupplier(NodeStore<MessageReference> 
nodeStore) {
    // The quantity of pagedReferences on messageReferences priority list
    private final AtomicInteger pagedReferences = new AtomicInteger(0);
 
-   // The estimate of memory being consumed by this queue. Used to calculate 
instances of messages to depage
-   final AtomicInteger queueMemorySize = new AtomicInteger(0);
+
+   final SizeAwareMetric queueMemorySize = new SizeAwareMetric();

Review Comment:
   @gemmellr I preferred to use the SizeAwareMetric here instead of introducing 
a new counter.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to