clebertsuconic commented on code in PR #4101:
URL: https://github.com/apache/activemq-artemis/pull/4101#discussion_r894155237
##########
artemis-server/src/main/java/org/apache/activemq/artemis/core/protocol/core/impl/wireformat/ReplicationPageEventMessage.java:
##########
@@ -54,7 +54,7 @@ public int expectedEncodeSize() {
@Override
public void encodeRest(final ActiveMQBuffer buffer) {
buffer.writeSimpleString(storeName);
- buffer.writeInt(pageNumber);
+ buffer.writeInt((int)pageNumber);
Review Comment:
I added versioning on the protocol, and a compatibility test where I'm
replicating between servers on different versions and using paging with
multiple protocols, and it's all good.
there's still a small possibility of a trunk if replication to or from a
previous version, but that will happen only if the user keeps running it
forever like this.. I don't think this is something that needs to be addressed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
