michaelpearce-gain commented on code in PR #4126:
URL: https://github.com/apache/activemq-artemis/pull/4126#discussion_r910327714
##########
artemis-server/src/main/java/org/apache/activemq/artemis/core/management/impl/view/predicate/ConsumerFilterPredicate.java:
##########
@@ -59,6 +62,28 @@ public boolean test(ServerConsumer consumer) {
return
matches(server.getSessionByID(consumer.getSessionID()).getRemotingConnection().getTransportConnection().getLocalAddress());
case REMOTE_ADDRESS:
return
matches(server.getSessionByID(consumer.getSessionID()).getRemotingConnection().getTransportConnection().getRemoteAddress());
+ case DELIVERING_COUNT:
+ return matches(consumer.getDeliveringMessages().size());
+ case DELIVERING_SIZE:
+ List<MessageReference> deliveringMessages =
consumer.getDeliveringMessages();
+ long deliveringMessageSize = 0;
Review Comment:
Ditto other comment i would be tracking this at the consumerimpl as messages
added or acl'd the size is added and removed so were not later looping, and
like wise avoid concurrent issues
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
