gemmellr commented on code in PR #4126:
URL: https://github.com/apache/activemq-artemis/pull/4126#discussion_r910816038
##########
artemis-server/src/main/java/org/apache/activemq/artemis/core/management/impl/ActiveMQServerControlImpl.java:
##########
@@ -2752,7 +2753,27 @@ public String listAllConsumersAsJSON() throws Exception {
}
private JsonObject toJSONObject(ServerConsumer consumer) throws Exception {
- JsonObjectBuilder obj =
JsonLoader.createObjectBuilder().add("consumerID",
consumer.getID()).add("connectionID",
consumer.getConnectionID().toString()).add("sessionID",
consumer.getSessionID()).add("queueName",
consumer.getQueue().getName().toString()).add("browseOnly",
consumer.isBrowseOnly()).add("creationTime",
consumer.getCreationTime()).add("deliveringCount",
consumer.getDeliveringMessages().size());
+ List<MessageReference> deliveringMessages =
consumer.getDeliveringMessages();
+ long deliveringMessageSize = 0;
+ for (int i = 0; i < deliveringMessages.size(); i++) {
+ MessageReference messageReference = deliveringMessages.get(i);
+ deliveringMessageSize +=
messageReference.getMessage().getEncodeSize();
+ }
+ long currentTime = System.currentTimeMillis();
+ long lastDeliveredTimeElapsed = consumer.getLastDeliveredTime() == 0 ? 0
: currentTime - consumer.getLastDeliveredTime();
+ long lastAckTimeElapsed = consumer.getLastAcknowledgedTime() == 0 ? 0 :
currentTime - consumer.getLastAcknowledgedTime();
+ JsonObjectBuilder obj = JsonLoader.createObjectBuilder()
+ .add("consumerID", consumer.getID())
+ .add("connectionID", consumer.getConnectionID().toString())
+ .add("sessionID", consumer.getSessionID())
+ .add("queueName", consumer.getQueue().getName().toString())
+ .add("browseOnly", consumer.isBrowseOnly())
+ .add("creationTime", consumer.getCreationTime())
+ .add("deliveringCount", deliveringMessages.size())
+ .add("deliveringSize", deliveringMessageSize)
+ .add("messagesAcknowledged", consumer.getMessagesAcknowledged())
+ .add("lastDeliveredTimeElapsed", lastDeliveredTimeElapsed)
+ .add("lastAcknowledgedTimeElapsed", lastAckTimeElapsed);
Review Comment:
Doesnt seem like it, I'm looking at a whole load of new lines being added
here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
