AntonRoskvist commented on code in PR #4192:
URL: https://github.com/apache/activemq-artemis/pull/4192#discussion_r957384807
##########
artemis-server/src/main/java/org/apache/activemq/artemis/core/postoffice/impl/PostOfficeImpl.java:
##########
@@ -1797,6 +1797,11 @@ private DuplicateCheckResult
checkBridgeDuplicateID(final Message message,
message.usageDown(); // this will cause large message delete
return DuplicateCheckResult.DuplicateNotStartedTX;
}
+ final byte[] duplicateIDBytes = message.getDuplicateIDBytes();
Review Comment:
I'm not going to argue this too much since it's is not causing me any issues
(just noticed by chance). My thinking was that for a reconnect the "local"
duplicateCache would catch duplicates directly from the producer, the
"bridgeCache" would catch duplicates from some network issue/routing loop
between brokers and the cache on the remote queue would catch a duplicate in
case of something like a client failover/loadbalance.
But if that's not right and this behavior is expected then I can close the
PR... again, it's not causing any issues, just seemed a bit strange.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
