clebertsuconic commented on code in PR #4192:
URL: https://github.com/apache/activemq-artemis/pull/4192#discussion_r957422676
##########
artemis-server/src/main/java/org/apache/activemq/artemis/core/postoffice/impl/PostOfficeImpl.java:
##########
@@ -1797,6 +1797,11 @@ private DuplicateCheckResult
checkBridgeDuplicateID(final Message message,
message.usageDown(); // this will cause large message delete
return DuplicateCheckResult.DuplicateNotStartedTX;
}
+ final byte[] duplicateIDBytes = message.getDuplicateIDBytes();
Review Comment:
So, there is a duplicate cache just for the bridge... I don't think we
should fill the duplicate cache for the producer since there's no producer
connected on this case. it would be a waste of resources...
It wouldn't be wrong.. just it would be doing extra work for no reason, as
there's no producer..
If you find an use case that you can explain the need, perhaps we can add
it, (even make it optional somehow)... but I think we would be better on not
having it on this case.
Thanks as usual though, your contributions are always great. Let me know
what you decide?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
