gtully commented on code in PR #4228:
URL: https://github.com/apache/activemq-artemis/pull/4228#discussion_r976480412
##########
tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/server/ConfigurationTest.java:
##########
@@ -122,6 +124,9 @@ public void testPropertiesConfigReload() throws Exception {
return mytopic_31.getBindings().size() == 3;
});
+ // verify round trip apply
+
Assert.assertTrue(server.getActiveMQServerControl().getStatus().contains("2"));
Review Comment:
I peeked a little more, and the reload does not use a new config object, so
the status update is visible before the update. If we want better feedback in
the future as to what was updated, once the changes were detected, it could be
coordinated and communicated via the status. For now, with properties in a
config map projection, I am happy that the status can reflect the refresh or
the projection and the reaction of the reload task.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
