gemmellr commented on code in PR #4228:
URL: https://github.com/apache/activemq-artemis/pull/4228#discussion_r976554051
##########
artemis-core-client/src/main/java/org/apache/activemq/artemis/api/core/management/ActiveMQServerControl.java:
##########
@@ -521,6 +521,9 @@ public interface ActiveMQServerControl {
@Attribute(desc = "The runtime size of the authorization cache")
long getAuthorizationCacheSize();
+ @Attribute(desc = "The current status of the server")
+ String getStatus();
+
Review Comment:
I dont think 'status' as an attribute is that general, it implies - and
actually outright states for its description here - that it returns the status
of the server, which I wouldnt really say it does in this case.
I think if the value is expected to be in a certain format later it should
adhere to that from the start...this is described on the JIRA and exposed as
being a freeform string set by the config, so 'other things adding keys later'
doenst seem to work / is effectively breaking.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
