cshannon commented on PR #927: URL: https://github.com/apache/activemq/pull/927#issuecomment-1298509865
> @cshannon we've noticed the spammy behavior when advisoryForSlowConsumer is enabled and it is not a reliable source for monitoring. > > I think long term, moving to more metrics is better than Advisories for monitoring related things. Advisory back pressure is a problem-- esp in networks, so I think we are best serve with treating Advisories as 'internal communication channel for brokers'. > > For monitoring and observability, having a way to identify slow consumers is _super_ important. I'll create a JIRA about turning slow consumer to a metric on destination and I think we should remove advisory for slow consumer. > > Similar to the dupe-from-store-send-to-dlq is now a counter vs creating extra IO of a copy of the message to the DLQ. I'm not against having a different/better approach but I don't think we should remove any advisories. I find several of them useful and rely on them for a lot of things. Even though this advisory is spammy someone could be using it (it works for topics) so I would be against removing it as it's off by default. If you don't need it just don't turn it on. I'm working on a PR for a new advisory for dispatched messages to consumers which I need for a use case I have but it will be similar to this and off by default. For now I think we should merge this as it fixes the broken behavior and again, it's off by default anyways but we advertise it as a feature. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
