cshannon commented on code in PR #927:
URL: https://github.com/apache/activemq/pull/927#discussion_r1010435045


##########
activemq-broker/src/main/java/org/apache/activemq/broker/region/Queue.java:
##########
@@ -2210,6 +2210,16 @@ private PendingList doActualDispatch(PendingList list) 
throws Exception {
                         // no further dispatch of list to a full consumer to
                         // avoid out of order message receipt
                         fullConsumers.add(s);
+
+                        //For full consumers we need to mark that they are 
slow and
+                        // then call the broker.slowConsumer() hook if 
implemented
+                        if (s instanceof PrefetchSubscription) {

Review Comment:
   You can't really add that check here because that callback could be used for 
many different things. Advisories is just one use case and implementation.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to