jbertram commented on PR #4307: URL: https://github.com/apache/activemq-artemis/pull/4307#issuecomment-1344780981
At this point two main things are not clear in your commit: 1. How to use your new Docker file. 2. How your new Docker file fits with the other Docker files already available. To resolve #1 you should probably just add some documentation. You could do this, for example, in the `artemis-docker/readme.md`. To resolve #2 you might also just add documentation. However, if the approach you've taken in this new Docker file is superior to the approach offered by the existing Docker files then it may be worth updating those to use your new approach so that users don't need to run `prepare-docker.sh` manually but they still have the option of using CentOS & Ubuntu with JDK or JRE. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
