jbertram commented on code in PR #4307:
URL: https://github.com/apache/activemq-artemis/pull/4307#discussion_r1047631946
##########
artemis-docker/Dockerfile-centos7-11:
##########
@@ -17,12 +17,30 @@
# ActiveMQ Artemis
+ARG CURRENT_VERSION=2.17.0
+
+FROM eclipse-temurin:11-jdk as builder
+ARG CURRENT_VERSION
+
+ENV VERSION=$CURRENT_VERSION
+
+RUN apt update -y && apt upgrade -y && apt install tree curl -y
+
+ADD ./prepare-docker.sh /bin/prepareDocker
+WORKDIR /root/artemis-build
+COPY ./Dockerfile-alpine .
Review Comment:
Shouldn't this be `COPY ./Dockerfile-centos7-11 .`?
##########
artemis-docker/readme.md:
##########
@@ -1,140 +1,62 @@
# Docker Image Example
This is an example on how you could create your own Docker Image For Apache
-ActiveMQ Artemis based on CentOS or Ubuntu (Eclipse Temurin JDK images).
+ActiveMQ Artemis based on Alpine, CentOS or Ubuntu (Eclipse Temurin JDK
images).
-# Preparing
+# Selecting the image
-Use the script ./prepare-docker.sh as it will copy the docker files under the
-binary distribution.
+This folder contains four different images for hosting your ActiveMQ Artemis
instance in docker
-Below is shown the command to prepare the build of the Docker Image starting
-from the local distribution (from the source codes of ActiveMQ Artemis)
+- Alpine
+- CentOS7
+- Ubuntu 11 with JDK
+- Ubuntu 11 with JRE
Review Comment:
`11` isn't the version of Ubuntu. It is the version of _Java_. Therefore,
the list should probably be:
- Alpine (latest) with JRE 11
- CentOS 7 with JDK 11
- Ubuntu (latest LTS) with JDK 11
- Ubuntu (latest LTS) with JRE 11
##########
artemis-docker/Dockerfile-ubuntu-11:
##########
@@ -17,8 +17,28 @@
# ActiveMQ Artemis
+ARG CURRENT_VERSION=2.17.0
+
+FROM eclipse-temurin:11-jdk as builder
+ARG CURRENT_VERSION
+
+ENV VERSION=$CURRENT_VERSION
+
+RUN apt update -y && apt upgrade -y && apt install tree curl -y
+
+ADD ./prepare-docker.sh /bin/prepareDocker
+WORKDIR /root/artemis-build
+COPY ./Dockerfile-alpine .
Review Comment:
Shouldn't this be `COPY ./Dockerfile-ubuntu-11 .`?
##########
artemis-docker/Dockerfile-ubuntu-11-jre:
##########
@@ -17,7 +17,30 @@
# ActiveMQ Artemis
+ARG CURRENT_VERSION=2.17.0
+
+FROM eclipse-temurin:11-jdk as builder
+ARG CURRENT_VERSION
+
+ENV VERSION=$CURRENT_VERSION
+
+RUN apt update -y && apt upgrade -y && apt install tree curl -y
+
+ADD ./prepare-docker.sh /bin/prepareDocker
+WORKDIR /root/artemis-build
+COPY ./Dockerfile-alpine .
Review Comment:
Shouldn't this be `COPY ./Dockerfile-ubuntu-11-jre .`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
