brusdev commented on code in PR #4362:
URL: https://github.com/apache/activemq-artemis/pull/4362#discussion_r1102924186
##########
artemis-cli/src/main/resources/org/apache/activemq/artemis/cli/commands/etc/jolokia-access.xml:
##########
@@ -23,7 +23,7 @@ under the License.
<restrict>
<cors>
- <!-- Allow cross origin access from ${http.host} ... -->
+ <!-- Allow cross origin access from ${http.host-for-comment} ... -->
Review Comment:
ncluding in a comment a hostname that doesn't match the real hostname is
confusing, what about just removing `${http.host}` from the comment?
```suggestion
<!-- Allow cross origin access from the origins that match the
following pattern -->
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
