brusdev commented on code in PR #4362:
URL: https://github.com/apache/activemq-artemis/pull/4362#discussion_r1103058743
##########
artemis-cli/src/main/resources/org/apache/activemq/artemis/cli/commands/etc/jolokia-access.xml:
##########
@@ -23,7 +23,7 @@ under the License.
<restrict>
<cors>
- <!-- Allow cross origin access from ${http.host} ... -->
+ <!-- Allow cross origin access from ${http.host-for-comment} ... -->
Review Comment:
A test would be good to avoid regressions.
Can you squash your commits and prepend the commit message with
`ARTEMIS-4160`, i.e.
```
ARTEMIS-4160 Handle hostnames with double dashes
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
