tabish121 commented on code in PR #4395:
URL: https://github.com/apache/activemq-artemis/pull/4395#discussion_r1128454402
##########
artemis-server/src/main/java/org/apache/activemq/artemis/core/paging/cursor/impl/PageCounterRebuildManager.java:
##########
@@ -186,6 +189,7 @@ public void run() {
}
public void rebuild() throws Exception {
+ logger.info("Rebuilding " + pgStore.getStoreName());
Review Comment:
Should be using logger formatting as opposed to string concats.
##########
artemis-server/src/main/java/org/apache/activemq/artemis/core/paging/cursor/impl/PageCounterRebuildManager.java:
##########
@@ -216,6 +220,11 @@ public void rebuild() throws Exception {
try (LinkedListIterator<PagedMessage> iter = msgs.iterator()) {
while (iter.hasNext()) {
PagedMessage msg = iter.next();
+ logger.info("Reading " + msg);
Review Comment:
Ditto
##########
artemis-server/src/main/java/org/apache/activemq/artemis/core/paging/PagingManager.java:
##########
@@ -85,6 +86,11 @@ public interface PagingManager extends ActiveMQComponent,
HierarchicalRepository
void injectMonitor(FileStoreMonitor monitor) throws Exception;
+ /** Execute a runnable inside the PagingManager's executor */
Review Comment:
Having the default method that violates the intended contract of the method
as documented seems less than ideal. If the intention is to prevent having to
add this to other PagingManager implementations that won't ever have this
method invoked then throwing an UnsupportedOperationException would be better
because at least then you might notice that the method is being used and not
doing something on a thread that was unintended.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
