gemmellr commented on code in PR #4395:
URL: https://github.com/apache/activemq-artemis/pull/4395#discussion_r1130761315
##########
artemis-server/src/main/java/org/apache/activemq/artemis/core/persistence/impl/journal/JournalStorageManager.java:
##########
@@ -797,6 +764,14 @@ private Map<Long, Pair<String, Long>>
recoverPendingLargeMessages() throws Excep
return largeMessages;
}
+ @Override
+ public void recoverLargeMessagesOnFolder(Set<Long> files) throws Exception {
+ List<String> filenames = largeMessagesFactory.listFiles("msg");
+ filenames.forEach(f -> {
+ files.add(getLargeMessageIdFromFilename(f));
+ });
+ }
Review Comment:
The List of filenames contains filenames, but the Set does not, it contains
the results added to it which are messageID, so it seems weird to call the Set
'files'.
The caller calls the same Set "storedLargeMessages" which seems nicer.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
