gemmellr commented on code in PR #4418:
URL: https://github.com/apache/activemq-artemis/pull/4418#discussion_r1154583919
##########
artemis-core-client/src/main/java/org/apache/activemq/artemis/core/client/ActiveMQClientLogger.java:
##########
@@ -344,4 +344,7 @@ public interface ActiveMQClientLogger {
@LogMessage(id = 214033, value = "Cannot resolve host ", level =
LogMessage.Level.ERROR)
void unableToResolveHost(UnknownHostException e);
+
+ @LogMessage(id = 214034, value = "{} is being garbage collected without
removing its resources.:\nlocations:\n{}", level = LogMessage.Level.INFO)
+ void debugMessageNotReleased(String clazz, String debugString);
Review Comment:
I hadnt actually noticed that those methods are defined in the Message
interface, since RefCountMessage doesnt actually indicate it implements
anything itself...but things subclass it to effectively implement the Message
methods, which makes it rather hard to see whats using it and what the original
impl is when the Message method is being overridden in various places.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
