clebertsuconic commented on code in PR #4418:
URL: https://github.com/apache/activemq-artemis/pull/4418#discussion_r1154455666
##########
artemis-core-client/src/main/java/org/apache/activemq/artemis/api/core/RefCountMessage.java:
##########
@@ -58,55 +108,35 @@ public int getDurableCount() {
public RefCountMessage getParentRef() {
return parentRef;
}
- // I am usually against keeping commented out code
- // However this is very useful for me to debug referencing counting.
- // Uncomment out anything between #ifdef DEBUG and #endif
- // #ifdef DEBUG -- comment out anything before endif if you want to debug
REFERENCE COUNTS
- //final ConcurrentHashSet<Exception> upSet = new ConcurrentHashSet<>();
- // #endif
+ protected void onUp() {
+ if (debugStatus != null) {
+ debugStatus.up(debugString());
+ }
+ }
- private void onUp() {
- // #ifdef DEBUG -- comment out anything before endif if you want to
debug REFERENCE COUNTS
- // upSet.add(new Exception("upEvent(" + debugString() + ")"));
- // #endif
+ protected void onFired() {
Review Comment:
I am going to rename this as accountedFor...
although I'm improving this... I'm only going to report an issue if there
was at least on onUp, so I will not need this as often... probably it will be
called by onFired only.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
