jbertram commented on code in PR #4421:
URL: https://github.com/apache/activemq-artemis/pull/4421#discussion_r1162068761
##########
artemis-server/src/main/java/org/apache/activemq/artemis/core/server/ServerSession.java:
##########
@@ -111,7 +112,7 @@ public interface ServerSession extends SecurityAuth {
void addCloseable(Closeable closeable);
- boolean checkAutoCreate(SimpleString address, RoutingType routingType)
throws Exception;
+ AutoCreateResult checkAutoCreate(QueueConfiguration queueConfiguration)
throws Exception;
Review Comment:
I like this idea, but I don't want it to be part of this PR as it has
already grown quite a bit larger than I originally anticipated. Also, care will
be necessary to limit the static methods so as to avoid the same kind of
"constructor hell" that I originally implemented `QueueConfiguration` to
address (among other things).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
