jbertram commented on code in PR #4421:
URL: https://github.com/apache/activemq-artemis/pull/4421#discussion_r1165748959
##########
artemis-commons/src/main/java/org/apache/activemq/artemis/api/core/QueueConfiguration.java:
##########
@@ -301,6 +338,7 @@ public QueueConfiguration setName(SimpleString name) {
if (CompositeAddress.isFullyQualified(name)) {
this.name = CompositeAddress.extractQueueName(name);
this.address = CompositeAddress.extractAddressName(name);
+ this.fqqn = true;
Review Comment:
Fixed.
##########
artemis-commons/src/main/java/org/apache/activemq/artemis/api/core/QueueConfiguration.java:
##########
@@ -607,6 +645,16 @@ public QueueConfiguration setAutoCreated(Boolean
autoCreated) {
return this;
}
+ /**
+ * Based on if the name or address uses FQQN when set
+ *
+ * defaults to {@code false}
+ * @return
+ */
+ public Boolean isFqqn() {
+ return fqqn == null ? false : fqqn;
Review Comment:
Fixed.
##########
artemis-junit/artemis-junit-4/src/test/java/org/apache/activemq/artemis/junit/EmbeddedActiveMQResourceCustomConfigurationTest.java:
##########
@@ -38,13 +38,16 @@ public class
EmbeddedActiveMQResourceCustomConfigurationTest {
static final String TEST_ADDRESS = "test.address";
QueueConfiguration queueConfiguration = new
QueueConfiguration(TEST_QUEUE).setAddress(TEST_ADDRESS);
- Configuration customConfiguration = new
ConfigurationImpl().setPersistenceEnabled(false).setSecurityEnabled(true).addQueueConfiguration(queueConfiguration);
+ Configuration customConfiguration = new
ConfigurationImpl().setPersistenceEnabled(false).setSecurityEnabled(true).addQueueConfiguration(queueConfiguration).addAcceptorConfiguration("amqp",
"tcp://localhost:5672");
Review Comment:
Fixed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
