clebertsuconic commented on code in PR #4430:
URL: https://github.com/apache/activemq-artemis/pull/4430#discussion_r1162809029
##########
artemis-server/src/main/java/org/apache/activemq/artemis/core/protocol/core/ServerSessionPacketHandler.java:
##########
@@ -1130,14 +1130,16 @@ private void sendContinuations(final int packetSize,
try {
session.send(session.getCurrentTransaction(),
EmbedMessageUtil.extractEmbedded((ICoreMessage) message.toMessage(),
storageManager), false, producers.get(senderID), false);
- } catch (Exception e) {
- message.deleteFile();
- throw e;
} catch (Throwable e) {
-
logger.warn("********************************************************************************");
- logger.warn("Throwable on currentLargeMessage {}",
message.getMessageID(), e);
-
logger.warn("********************************************************************************");
-
+ logger.warn(e.getMessage(), e);
Review Comment:
I thought the system was not really supposed to throw an exception at this
stage, and logging it would be only beneficial to finding what's going in a
production system.
I'm dealing with other cases where it's being hard to identify issues, and I
was trying to avoid that pattern here.
One thing is sending an expected exception to the client... (expected as
it's something related to the client's configuration...etc..) the other is a
server's exception not logging anything and only the client being informed
about it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
