gemmellr commented on code in PR #4430:
URL: https://github.com/apache/activemq-artemis/pull/4430#discussion_r1162887459
##########
artemis-server/src/main/java/org/apache/activemq/artemis/core/protocol/core/ServerSessionPacketHandler.java:
##########
@@ -1130,14 +1130,16 @@ private void sendContinuations(final int packetSize,
try {
session.send(session.getCurrentTransaction(),
EmbedMessageUtil.extractEmbedded((ICoreMessage) message.toMessage(),
storageManager), false, producers.get(senderID), false);
- } catch (Exception e) {
- message.deleteFile();
- throw e;
} catch (Throwable e) {
-
logger.warn("********************************************************************************");
- logger.warn("Throwable on currentLargeMessage {}",
message.getMessageID(), e);
-
logger.warn("********************************************************************************");
-
+ logger.warn(e.getMessage(), e);
Review Comment:
The code this method is calling looks to throw exceptions in fairly
'typical' situations, e.g security checks, disk usage checks. I think starting
to log a full stacktrace for every one of them, when it specifically didnt
before (presumably as the code calling this method should either handle, or
itself print, them), is likely asking for a lot of new questions. Along the
lines of the more typical 'I suddenly got this new error \<provides non-error
info log message and/or stacktrace\>'.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
