clebertsuconic commented on code in PR #4443:
URL: https://github.com/apache/activemq-artemis/pull/4443#discussion_r1174143682
##########
artemis-protocols/artemis-amqp-protocol/src/main/java/org/apache/activemq/artemis/protocol/amqp/connect/mirror/AMQPMirrorControllerSource.java:
##########
@@ -76,14 +77,20 @@ public class AMQPMirrorControllerSource extends
BasicMirrorController<Sender> im
public static final Symbol INTERNAL_ID =
Symbol.getSymbol("x-opt-amq-mr-id");
public static final Symbol INTERNAL_DESTINATION =
Symbol.getSymbol("x-opt-amq-mr-dst");
+ /** When a clustered node (from regular cluster connections) receives a
message
+ it will have target queues associated with it
+ this could be from message redistribution or simply load balancing.
+ an that case this will have the queue associated with it */
+ public static final Symbol TARGET_QUEUES =
Symbol.getSymbol("x-opt-amq-trg-q");
+
// Capabilities
public static final Symbol MIRROR_CAPABILITY =
Symbol.getSymbol("amq.mirror");
public static final Symbol QPID_DISPATCH_WAYPOINT_CAPABILITY =
Symbol.valueOf("qd.waypoint");
public static final SimpleString INTERNAL_ID_EXTRA_PROPERTY =
SimpleString.toSimpleString(INTERNAL_ID.toString());
public static final SimpleString INTERNAL_BROKER_ID_EXTRA_PROPERTY =
SimpleString.toSimpleString(BROKER_ID.toString());
- private static final ThreadLocal<RoutingContext> mirrorControlRouting =
ThreadLocal.withInitial(() -> new
RoutingContextImpl(null).setMirrorDisabled(true));
+ private static final ThreadLocal<RoutingContext> mirrorControlRouting =
ThreadLocal.withInitial(() -> new
RoutingContextImpl(null).setMirrorOption(MirrorOption.disabled));
Review Comment:
This is actually what it is... controlling what's the outcome of Mirroring..
in the case Routing will produce no mirroring. which is exactly what's being
set here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
