gemmellr commented on code in PR #4443: URL: https://github.com/apache/activemq-artemis/pull/4443#discussion_r1175004814
########## artemis-server/src/main/java/org/apache/activemq/artemis/core/server/MirrorOption.java: ########## @@ -0,0 +1,25 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.activemq.artemis.core.server; + +/** This is to be used in conjunction with RoutingContext, where we control certain semantics during routing. + * */ +public enum MirrorOption { Review Comment: Having it occupy the 'prime real estate' of the name MirrorOption at the very root of the code namepsace seems wrong given what its used for. Its not for holding general options for the mirror, its a fairly niche almost-internal routing control setting for use with RoutingContext. Even if were left it named MirrorOption, it still seems like it would be far nicer as a nested enum within RoutingContext, the only place it is used and seems likely to be used. None of the impl-only code using it would change really beyond just updating their import (probably even removing one for RoutingContextImpl actually) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
